Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed unbound global variables in pywin.dialogs.ideoptions.OptionsPropPage's OnFormat* methods + re-enable pyright's reportUnboundVariable #2283

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fixed unbound global variables in pywin.dialogs.ideoptions.OptionsPropPage's OnFormat* methods + re-enable pyright's reportUnboundVariable #2283

wants to merge 6 commits into from

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Jun 4, 2024

Looking at the implementation of interact.SaveFontPreferences this almost certainly meant to use the variables in interact. Although these still fail because calling self.GetFormat results in AttributeError: 'PyCPropertyPage' object has no attribute 'GetFormat':

>>> from pywin.dialogs import ideoptions; ideoptions.OptionsPropPage().OnFormatInput(None,None)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Program Files\Python39\lib\site-packages\Pythonwin\pywin\dialogs\ideoptions.py", line 122, in OnFormatInput
    fmt = self.GetFormat(formatInput)
  File "C:\Program Files\Python39\lib\site-packages\Pythonwin\pywin\mfc\object.py", line 24, in __getattr__
    return getattr(o, attr)
AttributeError: 'PyCPropertyPage' object has no attribute 'GetFormat'

For all I know these methods might always have been broken in the past 25 years. At least this allows us to turn on reportUnboundVariable in pyright.

Avasam
Avasam commented Jun 4, 2024
View reviewed changes
CHANGES.txt Outdated Show resolved Hide resolved
@Avasam Avasam changed the title Fixed unbound global variables in pywin.dialogs.ideoptions.OptionsPropPage's OnFormat* methods Fixed unbound global variables in pywin.dialogs.ideoptions.OptionsPropPage's OnFormat* methods + re-enable pyright's reportUnboundVariable Oct 4, 2024
@Avasam Avasam mentioned this pull request Oct 4, 2024
Closed
@Avasam Avasam requested a review from mhammond October 18, 2024 18:40
Avasam
Avasam commented Oct 23, 2024
View reviewed changes
pyrightconfig.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhammond mhammond Awaiting requested review from mhammond

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Avasam